timesync: Fix automatic vsock device creation

[cfergeau]

Timesync uses a vsock port for guest/host time synchronization.
When timesync is in use, if the VM has no vsock device, a new one is
automatically added.
However this got broken in commit a5db53d as we were generating the
hypervisor configuration before adding this device.

This means timesync only worked if you had another vsock device
configured.

[anjannath]

so the vsock config should be part of virtualMachineConfig before calling cfg.SetSocketDevicesVirtualMachineConfiguration(cfg.socketDevicesConfiguration)

[cfergeau]

so the vsock config should be part of virtualMachineConfig before calling cfg.SetSocketDevicesVirtualMachineConfiguration(cfg.socketDevicesConfiguration)

I've added this to the commit log to make it clearer.

[praveenkumar]

Since we are thinking about using crc-org/crc#4341 (comment) way for timesync should we try that and drop it completely from this repo?

[cfergeau]

Since we are thinking about using crc-org/crc#4341 (comment) way for timesync should we try that and drop it completely from this repo?

After we add makestep ... to the bundle and it works fine, we can consider dropping this timesync code. We are not there yet, so better to keep it working, especially as the fix is not complicated.

[anjannath]

@cfergeau commit log has some file listings, that i guess got pasted while amending commit, could you please remove that

[cfergeau]

@cfergeau commit log has some file listings, that i guess got pasted while amending commit, could you please remove that

hrm yes, happens more often than not because of some broken process on my end. Fixed now.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anjannath
Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment