Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Set minimum supported version to macOS 12 #197

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

cfergeau
Copy link
Collaborator

@cfergeau cfergeau commented Sep 30, 2024

macOS 11 github runners are no longer available so we no longer build
and test vfkit on this platform.
macOS 11 has been out of support for a year now.
This commit changes the minimum supported version to macOS 12.
A mention of macOS 11 is kept, we'll remove it when we'll know for sure
vfkit is broken on this platform

This PR also adds some package-level go documentation to (hopefully) make it easier to get into the codebase

Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

macOS 11 github runners are no longer available so we no longer build
and test vfkit on this platform.
macOS 11 has been out of support for a year now.
This commit changes the minimum supported version to macOS 12.
A mention of macOS 11 is kept, we'll remove it when we'll know for sure
vfkit is broken on this platform

Signed-off-by: Christophe Fergeau <[email protected]>
Copy link

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks correct to me 👍

@cfergeau cfergeau merged commit 973cb1a into crc-org:main Oct 7, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants