virtionet: testing connectUnixPath #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstocchi
force-pushed
the
testVirtionet
branch
from
d52b77c
to
cf719ce
Compare
cfergeau
reviewed
Oct 2, 2024
| }) | ||
|
|
||
| t.Run("Failed connection - End socket longer than 104 bytes", func(t *testing.T) { | ||
| // Retrieve HOME env variable (used by the os.UserHomeDir) |
There was a problem hiding this comment.
Ah right, kind of messy to do the 100 bytes test with current main :/ This will need to be modified once #195 gets in.
|
Can you squash all 3 commits together? I don't think it's really useful to keep all 3 in our git history. |
lstocchi
force-pushed
the
testVirtionet
branch
2 times, most recently
from
ed32f4f
to
e77812d
Compare
|
@cfergeau updated |
anjannath
reviewed
Oct 3, 2024
it adds tests for connectUnixPath and localUnixSocketPath func in virtionet.go it mainly test the use case where one end of the unixgram socket is longer of 104 bytes resulting in a failure. On macOS, a path on the filesystem can have a max of 104 bytes length
lstocchi
force-pushed
the
testVirtionet
branch
from
e77812d
to
d7b2799
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds tests for connectUnixPath and localUnixSocketPath func in virtionet.go.
It mainly test the use case where one end of the unixgram socket is longer of 104 bytes resulting in a failure.