virtionet: Add gvproxy support #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes --device virtio-net,unixSocketPath= which was non-functional
until now, it was not using the correct socket type ("unix" instead of
"unixgram"). This commit fixes this.
Immediately after DialUnix("unixgram"), vfkit sends the magic string
"VFKT" so that the other end knows where to send the data to (there is
no `Accept` with unixgram sockets).
There could be a better way but I'm not aware of it.
This can be tested with gvproxy 0.6.2:
term1$ gvproxy --listen unix:///tmp/gvproxy-http.sock --listen-vfkit unixgram:///tmp/gvproxy.sock
term2$ vfkit --device virtio-net,unixSocketPath=/tmp/gvproxy.sock,mac=5a:94:ef:e4:0c:ee [...]
Trying to prevent vf/virtio.go from getting too big.
Adds adhoc signal catching to remove the unix socket file vfkit created. This should be moved to a higher level/made more generic/...
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes --device virtio-net,unixSocketPath= which was non-functional
until now, it was not using the correct socket type ("unix" instead of
"unixgram"). This commit fixes this. Immediately after
DialUnix("unixgram"), vfkit sends the magic string
"VFKT" so that the other end knows where to send the data to (there is no
Acceptwith unixgram sockets). There could be a better way but I'm notaware of it.