tests: Add basic e2e test #61
Conversation
cfergeau
force-pushed
the
puipui
branch
4 times, most recently
from
201a6ea
to
95e260c
Compare
|
one thing i noticed is that the tests are downloading the puipui linux tarball multiple times (one download for each test scenario) which is fine since it is very small in size, but if we do test fedora or some other real distro we need to implement OSProvider to download the image only once |
cfergeau
force-pushed
the
puipui
branch
3 times, most recently
from
e606461
to
1dec9be
Compare
|
/hold |
cfergeau
force-pushed
the
puipui
branch
4 times, most recently
from
bc18ca4
to
ebdf6ee
Compare
|
/unhold |
Yep, this definitely needs improvements :) |
|
/lgtm |
This reuses the puipui linux work from Code-Hex/vz. The OS is abstracted with a OSProvider interface which will hopefully be implementable with Fedora CoreOS or other distros. Tests which are currently implemented: - start a VM, and make sure it's possible to connect through ssh (both over a regular network interface, and over vsock) - for most devices, run lspci to make sure it's present in the VM - vsock-listen and vsock-connect - file sharing Signed-off-by: Christophe Fergeau <[email protected]>
Signed-off-by: Christophe Fergeau <[email protected]>
In the next commits, we want to avoid running the macOS13-specific tests on older macOS versions. Signed-off-by: Christophe Fergeau <[email protected]>
This will solve some test failures on macOS 12. There are likely more issues to fix on macOS 11. Signed-off-by: Christophe Fergeau <[email protected]>
The newly added e2e tests will fail on macos 11. it's 3 major releases behind (macos 14 was released a few months ago), I prefer not to spend too much time on it for now. Signed-off-by: Christophe Fergeau <[email protected]>
Running 'make' twice currently results in an error: ``` % make CGO_ENABLED=1 CGO_CFLAGS=-mmacosx-version-min=11.0 GOOS=darwin GOARCH=amd64 go build -o out/vfkit-amd64 ./cmd/vfkit codesign --entitlements vf.entitlements -s - out/vfkit-amd64 out/vfkit-amd64: is already signed make: *** [out/vfkit-amd64] Error 1 ``` This commit makes use of "codesign -f" to force the re-generation of a signature even if the binarie did not change. This works around the previous error. Signed-off-by: Christophe Fergeau <[email protected]>
We don't really need the other ones.. Signed-off-by: Christophe Fergeau <[email protected]>
cfergeau
force-pushed
the
puipui
branch
2 times, most recently
from
c0491d3
to
8fbd4dc
Compare
|
/lgtm |
|
/lgtm |
|
/approve |
2 similar comments
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath, cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reuses the puipui linux work from Code-Hex/vz.
The OS is abstracted with a OSProvider interface which will hopefully
be implementable with Fedora CoreOS or other distros.
Tests which are currently implemented:
over a regular network interface, and over vsock)