refactor: improve code for wait vm to reach the specified state #75
Conversation
In previous implementations, there was a need to maintain a timeout error variable to ignore while waiting for the VM to stop. This part of the code was not intuitive enough, and other maintainers couldn’t grasp its intention at first glance. This improvement has optimized the `waitForVMState` function by adding a timeout parameter, making the code more intuitive. Signed-off-by: Black-Hole1 <[email protected]>
|
Hi @BlackHole1. Thanks for your PR. I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
There was a problem hiding this comment.
The main reason for this timeout at start time was to avoid an infinite loop if there's a virtualization error early.
But after 52a4bc5 I'm not sure this timeout is still useful, it can probably be removed.
These changes look good to me as is, I'll need to test them before merging.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@cfergeau take this after this week's meeting, or let us test this as part of the other changes? |
In previous implementations, there was a need to maintain a timeout error variable to ignore while waiting for the VM to stop.
This part of the code was not intuitive enough, and other maintainers couldn’t grasp its intention at first glance.
This improvement has optimized the
waitForVMStatefunction by adding a timeout parameter, making the code more intuitive.