Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from requests to httpx #8

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Switch from requests to httpx #8

merged 2 commits into from
Nov 15, 2023

Conversation

jodal
Copy link
Member

@jodal jodal commented Nov 15, 2023

  • Switch from requests to httpx
  • Reuse HTTP connections across requests

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (4328ed8) 88.13% compared to head (d010da9) 85.92%.

Files Patch % Lines
src/brreg/enhetsregisteret/_client.py 75.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   88.13%   85.92%   -2.21%     
==========================================
  Files           5        5              
  Lines         118      135      +17     
  Branches       19       20       +1     
==========================================
+ Hits          104      116      +12     
- Misses         10       14       +4     
- Partials        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jodal jodal merged commit 9fcb437 into main Nov 15, 2023
5 checks passed
@jodal jodal deleted the httpx branch November 15, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants