Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transactionを削除する #292

Open
ochaochaocha3 opened this issue Aug 8, 2021 · 0 comments
Open

transactionを削除する #292

ochaochaocha3 opened this issue Aug 8, 2021 · 0 comments
Labels

Comments

@ochaochaocha3
Copy link
Member

メッセージのアーカイブやIRCボット、タスクなどに ApplicationRecord.transaction で囲んでいる部分があるが、Mroongaはトランザクションにもセーブポイントにも対応していないので、意味がない。Railsはそうとは知らずにSQLの BEGINCOMMITSAVEPOINT を実行するので、挙動が読めなくなる。そのため、ApplicationRecord.transaction で囲むのはやめて、必要ならば自前で実装する。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant