Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelLastSpeech: 発言がない場合に refresh! が失敗しないようにする #291

Merged
merged 8 commits into from
Aug 26, 2021

Conversation

ochaochaocha3
Copy link
Member

@ochaochaocha3 ochaochaocha3 commented Aug 1, 2021

Fixes #198

チャンネルに発言がない場合に ChannelLastSpeech.refresh! を実行すると、conversation_message が存在しないというバリデーションエラーで失敗していました。これが発生しないように修正します。

変更の概要

チャンネルに発言がない場合に ChannelLastSpeech.refresh! を
実行すると失敗することを確認するため。
@ochaochaocha3 ochaochaocha3 self-assigned this Aug 1, 2021
ChannelLastSpeech.refresh! の動作変更に合わせて調整する。
テストを追加して正常動作を確認する。
@ochaochaocha3 ochaochaocha3 force-pushed the fix-channel_last_speech-refresh-without_messages branch 13 times, most recently from d20b0e4 to d4923c4 Compare August 1, 2021 16:14
@ochaochaocha3 ochaochaocha3 force-pushed the fix-channel_last_speech-refresh-without_messages branch from d4923c4 to b8ea910 Compare August 8, 2021 08:12
test-unit-railsに移行したため不要。
@ochaochaocha3 ochaochaocha3 requested a review from koi-chan August 8, 2021 08:56
@ochaochaocha3 ochaochaocha3 marked this pull request as ready for review August 8, 2021 09:39
@ochaochaocha3 ochaochaocha3 changed the title [WIP] ChannelLastSpeech: 発言がない場合に refresh! が失敗しないようにする ChannelLastSpeech: 発言がない場合に refresh! が失敗しないようにする Aug 8, 2021
Copy link
Member

@koi-chan koi-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
マージします。

@koi-chan koi-chan merged commit 38ff6d5 into master Aug 26, 2021
@koi-chan koi-chan deleted the fix-channel_last_speech-refresh-without_messages branch August 26, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

メッセージを非表示化する機能のテストを追加する
2 participants