-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChannelLastSpeech: 発言がない場合に refresh! が失敗しないようにする #291
Merged
koi-chan
merged 8 commits into
master
from
fix-channel_last_speech-refresh-without_messages
Aug 26, 2021
Merged
ChannelLastSpeech: 発言がない場合に refresh! が失敗しないようにする #291
koi-chan
merged 8 commits into
master
from
fix-channel_last_speech-refresh-without_messages
Aug 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
チャンネルに発言がない場合に ChannelLastSpeech.refresh! を 実行すると失敗することを確認するため。
バリデーションエラー対策。
ChannelLastSpeech.refresh! の動作変更に合わせて調整する。 テストを追加して正常動作を確認する。
ochaochaocha3
force-pushed
the
fix-channel_last_speech-refresh-without_messages
branch
13 times, most recently
from
August 1, 2021 16:14
d20b0e4
to
d4923c4
Compare
ochaochaocha3
force-pushed
the
fix-channel_last_speech-refresh-without_messages
branch
from
August 8, 2021 08:12
d4923c4
to
b8ea910
Compare
Rubocopの指摘を反映する。
test-unit-railsに移行したため不要。
ochaochaocha3
changed the title
[WIP] ChannelLastSpeech: 発言がない場合に refresh! が失敗しないようにする
ChannelLastSpeech: 発言がない場合に refresh! が失敗しないようにする
Aug 8, 2021
koi-chan
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!
マージします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
チャンネルに発言がない場合に
ChannelLastSpeech.refresh!
を実行すると、conversation_message
が存在しないというバリデーションエラーで失敗していました。これが発生しないように修正します。変更の概要
ChannelLastSpeech.refresh!
ConversationMessageArchiver
:ChannelLastSpeech.refresh!
の変更に伴い呼び出し方を合わせました。ChannelLastSpeech.refresh!
のテストを追加しました。TRUNCATE TABLE
によってデータを消去するようにしました。次の変更によって実現しています。ActiveSupport::TestCase
においてself.use_transaction_tests
をfalse
に設定する。delete_all
するのをやめました。