-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX build fix #32
base: master
Are you sure you want to change the base?
OSX build fix #32
Conversation
Thank you. What exactly does "(tests fail)" mean? There's not much point in having the build "fixed" when it doesn't actually work... |
Test results:
|
Please consider merging this PR and republishing to NPM. Your package cannot be built on Mac OS X as is. |
@WolfgangFellger @rashfael Please consider merging this PR |
Neither @WolfgangFellger nor I are with creatale anymore, sorry. |
@krithixy I merged @diegoperini's fixes (this PR) into my fork: https://github.com/thlorenz/ndv and published as I hope we can get the other PRs that are pending here merged there as well and thus keep it working on all platforms. |
@thlorenz You should consider editting the README as well as the repo description to indicate your fork has a purpose other than assuming ownership. You may add something like "A fork of node-dv with OS X build fix". 👍 |
@diegoperini it already provides that info as a github feature, i.e. look at the top of the repo it'll say where it was forked from. |
Edit: Fixed minimum OSX