Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar close on body click #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abhinand-c
Copy link

Fix for issue of sidebar not collapsing upon body click.
Fix Issue #55

Fix for issue of sidebar not collapsing upon body click.
update fix sidenavbar
Issue creativetimofficial#55
@jhonnattan123
Copy link

please include this

#38

and add defualt in click event

This is because when the screen is resized, the option to hide the menu is broken
image

@jhonnattan123
Copy link

and modify
image
to
image

@dragosct dragosct requested a review from rarestoma October 12, 2020 07:35
@DaWe35
Copy link

DaWe35 commented Oct 29, 2020

Ohh no I spend hours doing the same @timcreative please merge!

@DaWe35
Copy link

DaWe35 commented Nov 29, 2020

thank you dear big bro ,
It's Work 101% ...
I but in mobile when we click sidnav not close still
can you please help me ....

thank you once agin

I think we already fixed in https://github.com/DaWe35/SkyID/blob/main/dist/assets/js/argon.js
Issue, commits: DaWe35/SkyID#20

@daniel-farina
Copy link

This should be merged, it's a big issue. The sidebar is completely stuck on body click. It's def a bug.

Thanks for the fix guys.

@iyobo
Copy link

iyobo commented May 17, 2021

@timcreative please merge

@rarestoma
Copy link
Contributor

Hi guys,

Thank you for working with our products and for fixing this issue.

I just added it in the 'to do' list for the next update.

Best regards,
Rares

@jovialcore
Copy link

Hi...what is the update ? I highly recommended this pull request be merge. Nice work @abhinand-c abhinand-c @rarestoma what is the update please. Nice work @timcreative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants