Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global NATS interceptor implementation #1091

Merged

Conversation

tipusinghaw
Copy link
Contributor

@tipusinghaw tipusinghaw commented Dec 30, 2024

What

  • Implemented NATS interceptor for NATS error message

Why

  • Not able to customize the NATS error messages

Copy link

@GHkrishna
Copy link
Contributor

GHkrishna commented Dec 30, 2024

Good job 👍

Out of curiosity, will we also be getting the service name which throws the error in the error message.

Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@tipusinghaw
Copy link
Contributor Author

Good job 👍

Out of curiosity, will we also be getting the service name which throws the error in the error message.

Not in the current state of the codebase, for that we might need to intercept the message from every service and add the service name (Just a thought)

@GHkrishna
Copy link
Contributor

Not in the current state of the codebase, for that we might need to intercept the message from every service and add the service name (Just a thought)

That seems interesting, it would be great if we could achieve that. Because that way we can easily recognize the service that might be down.

We can add an interceptor like you mentioned, and maybe explore if NATS provides any out of the box capabilities or if we can provision service name in the error object at the time of throwing the error itself

@bhavanakarwade bhavanakarwade merged commit 337fdf0 into develop-dco-fixed Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants