Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate attributes in proof request #1092

Merged
merged 6 commits into from
Jan 2, 2025
Merged

fix: duplicate attributes in proof request #1092

merged 6 commits into from
Jan 2, 2025

Conversation

pranalidhanavade
Copy link
Contributor

@pranalidhanavade pranalidhanavade commented Dec 31, 2024 •
edited
Loading

What

  • Changes in send proof request API attributes validation to add support to identical attributes in the different schemas.

@pranalidhanavade pranalidhanavade self-assigned this Dec 31, 2024
@GHkrishna GHkrishna added the bug Something isn't working label Dec 31, 2024
@pranalidhanavade
added error messages in common file
5b41cc1 
Signed-off-by: pranalidhanavade <[email protected]>
GHkrishna
GHkrishna requested changes Dec 31, 2024
View reviewed changes
apps/api-gateway/src/verification/verification.controller.ts Outdated Show resolved Hide resolved
apps/api-gateway/src/verification/verification.controller.ts Outdated Show resolved Hide resolved
libs/common/src/validator.ts Outdated Show resolved Hide resolved
@pranalidhanavade
resolved comments on PR
fbcb6ba 
Signed-off-by: pranalidhanavade <[email protected]>
GHkrishna
GHkrishna approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pranalidhanavade pranalidhanavade changed the title fix: duplicate attributes issue in proof request fix: duplicate attributes in proof request Jan 2, 2025
tipusinghaw
tipusinghaw approved these changes Jan 2, 2025
View reviewed changes
libs/common/src/response-messages/index.ts Outdated Show resolved Hide resolved
@pranalidhanavade
resolved comments on PR
5bd79ed 
Signed-off-by: pranalidhanavade <[email protected]>
@pranalidhanavade
fix: resolve comments on PR
6646ff4 
Signed-off-by: pranalidhanavade <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

GHkrishna
GHkrishna approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pranalidhanavade pranalidhanavade merged commit 5f2baf8 into develop-dco-fixed Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

@GHkrishna GHkrishna GHkrishna approved these changes

Assignees

@pranalidhanavade pranalidhanavade

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranalidhanavade @GHkrishna @tipusinghaw