Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.5 to 6.…

…0.4 (#232)

* Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.5 to 6.0.4

Bumps [com.github.spotbugs.snom:spotbugs-gradle-plugin](https://github.com/spotbugs/spotbugs-gradle-plugin) from 5.2.5 to 6.0.4.
- [Release notes](https://github.com/spotbugs/spotbugs-gradle-plugin/releases)
- [Commits](spotbugs/spotbugs-gradle-plugin@5.2.5...6.0.4)

---
updated-dependencies:
- dependency-name: com.github.spotbugs.snom:spotbugs-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix new spotbug issues

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andy Coates <[email protected]>

buildSrc/build.gradle.kts

@@ -42,7 +42,7 @@ tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach
 }
 
 dependencies {
-    implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.2.5")                // https://plugins.gradle.org/plugin/com.github.spotbugs
+    implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:6.0.4")                // https://plugins.gradle.org/plugin/com.github.spotbugs
     implementation("com.diffplug.spotless:spotless-plugin-gradle:6.23.3")                   // https://plugins.gradle.org/plugin/com.diffplug.spotless
     implementation("gradle.plugin.org.kt3k.gradle.plugin:coveralls-gradle-plugin:2.12.2")   // https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
     implementation("org.javamodularity:moduleplugin:1.8.12")                                // https://plugins.gradle.org/plugin/org.javamodularity.moduleplugin

src/main/java/org/creekservice/api/system/test/gradle/plugin/SystemTestExtension.java

@@ -75,15 +75,18 @@ public void verificationTimeout(final Duration timeout) {
 
     /**
      * @return list of additional arguments to pass to the test executor
-     *     <p>See https://github.com/creek-service/creek-system-test/tree/main/executor for more
-     *     info.
+     *     <p>See <a
+     *     href="https://github.com/creek-service/creek-system-test/tree/main/executor">Executor
+     *     docs</a> for more info.
      */
     public abstract ListProperty<String> getExtraArguments();
 
     /**
      * Set additional args to pass to the test executor.
      *
-     * <p>See https://github.com/creek-service/creek-system-test/tree/main/executor for more info.
+     * <p>See <a
+     * href="https://github.com/creek-service/creek-system-test/tree/main/executor">Executor
+     * docs</a> for more info.
      *
      * @param args the extra args to use when running system tests.
      */
@@ -108,4 +111,9 @@ public DebugExtension getDebugging() {
     public void debugging(final Action<DebugExtension> action) {
         action.execute(debugExt);
     }
+
+    // Avoid finalizer attacks: spotbugs CT_CONSTRUCTOR_THROW
+    @SuppressWarnings("deprecation")
+    @Override
+    protected final void finalize() {}
 }