HW5 #8
Open
HW5 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Можно создавать и выводить объекты. Сейчас будет приделывать старые/новые коды к этому интерфейсу.
Надо бы ещё добавиться валидацию формы...
Связал с классами событий и колекций. Проблема с удалением элементов удаляется только половина потомков.
|
|
||
| /////////////////Описание обработчика добавления события//////////////// | ||
| addButton = document.getElementById('createButton'); | ||
| addButton.addEventListener('click', function(event){ |
There was a problem hiding this comment.
Функция очень перегружена. Есть такая практика, что обработчик события должен быть максимально разгруженным буквально пара строк.
addButton.addEventListener('click', function(event) {
doFirst();
doSecond();
});
|
Прописываю тебе JSLint 2 раза в день :) |
|
4 задание пропущено BTW |
|
|
||
|
|
||
|
|
||
| var Collection = function(data){ |
There was a problem hiding this comment.
Вынеси каждый конструктор в отдельный файл
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Немного работает, но возникли проблемы с удалением элементов.