-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial typing annotation support + add mypy #82
Open
mbrulatout
wants to merge
9
commits into
master
Choose a base branch
from
typing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids conflicting with bool type for further type annotations
mbrulatout
requested review from
dclaisse,
pierrecdn,
cpaillet,
mougams and
manu-ns
September 2, 2024 08:24
manu-ns
approved these changes
Sep 2, 2024
manu-ns
reviewed
Sep 2, 2024
# error whenever a function with type annotations calls a function defined without annotations | ||
#disallow_untyped_calls = true | ||
# stop treating arguments with a None default value as having an implicit Optional type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPT: remove these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some trivial typing, coupled with some mypy conf, required quite a few changes.
This is a partial support for typing. More to follow, the ultimate goal being the addition of a py.typed file.
To fix a conflict with the bool type annotation,
CB.bool()
was renamed toCB.boolean()
.Used the 3.11 annotation, requiring importing from future
Added mypy conf in pyproject.toml + enabled in pre-submit
disallow_untyped_defs is still disabled.