Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buildx to build multi architecture images #104

Closed
wants to merge 5 commits into from
Closed

Use buildx to build multi architecture images #104

wants to merge 5 commits into from

Conversation

austinhallett
Copy link

No description provided.

@austinhallett
Copy link
Author

Note this PR is still a WIP but I did notice that there was another PR wit a similar goal opened here #86 (reference)
I am wondering if the team prefers to use the shell script, or the gha workflow.

At the end of the day, I do not personally care how I get arm containers, but I am in dire need. Let me know how I can assist in moving this effort forward.

@moto-timo
Copy link
Member

Note this PR is still a WIP but I did notice that there was another PR wit a similar goal opened here #86 (reference) I am wondering if the team prefers to use the shell script, or the gha workflow.

At the end of the day, I do not personally care how I get arm containers, but I am in dire need. Let me know how I can assist in moving this effort forward.

In the history of this project, we have already switched from Travis CI to GitHub Actions. We expect the project to live beyond GitHub Actions to the next shiny thing. The way to avoid that vendor lock-in is with the shell scripts.

@moto-timo
Copy link
Member

Please please please stop making the whitespace changes. It is extremely difficult to review.

@moto-timo
Copy link
Member

I will not proceed with review until you squash the commits and remove the whitespace changes. Make sure you are enabling GitHub Actions on your fork and that you are testing the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants