Improve Ubuntu/Debian container configs, add Ubuntu 20.04 and update buildtools #43
Conversation
pbrkr
commented
May 4, 2020
•
pbrkr
commented
- Improve the Debian & Ubuntu container configs to resolve issues seen with my use cases.
- Add a Dockerfile for Ubuntu 20.04
- Updated to buildtools-extended tarball from Yocto 3.1 for Centos 7 & Ubuntu 16.04.
|
@rewitt1: Ping. |
|
@pbrkr Sorry this has been sitting for so long. I was on leave. I'll review it today. |
Running apt-get in noninteractive mode ensures we will never be asked any configuration questions when installing packages. Signed-off-by: Paul Barker <[email protected]>
This allows 32-bit host tools and setup programs written in C++ to be used on 64-bit host systems during the build. Signed-off-by: Paul Barker <[email protected]>
Ubuntu defaults to using dash to provide /bin/sh. This is a lightweight shell which doesn't handle some of the bashisms present in many Yocto recipes from third-party layers, leading to weird and hard to debug build failures when it is used. Signed-off-by: Paul Barker <[email protected]>
Based on the existing Dockerfile for Ubuntu 18.04. Copyright year updated as requested by Intel. Signed-off-by: Paul Barker <[email protected]>
Signed-off-by: Paul Barker <[email protected]>
Python sets do not have a guaranteed sort order so the order of elements in `intersection` may not match the order of elements in `extraconflines`. To prevent random test failures the lists should be sorted before comparison. Signed-off-by: Paul Barker <[email protected]>
Signed-off-by: Paul Barker <[email protected]>
By switching to buildtools-extended we no longer need to separately install a newer gcc version in Centos 7. Also switch to using sha256sum to validate the download instead of the obsolete md5sum. Signed-off-by: Paul Barker <[email protected]>
The new requirement for gcc 6.0 or later isn't met by Ubuntu 16.04. The distro-entry script is also modified to enable buildtools whenever they have been installed. Signed-off-by: Paul Barker <[email protected]>
pbrkr
changed the title
|
@rewitt1: All green now, sorry for the noise there. |
There was a problem hiding this comment.
Do you happen to have changes queued for distro-entry.sh in the https://github.com/crops/poky-container repo?
I wanted to check before I decided to that myself after merging these changes.
| COPY install-buildtools.sh / | ||
| RUN bash /install-buildtools.sh && \ | ||
| rm /install-buildtools.sh | ||
|
|
There was a problem hiding this comment.
Hi @pbrkr,
The commit message has
The distro-entry script is also modified to enable buildtools whenever
they have been installed.
That looks to be part of the next patch, but I wanted to clarify and be sure I'm not missing part of this patch.
There was a problem hiding this comment.
That may have got mixed up, I rebased the patches a few times.
Sorry for the late reply, gmail must have dropped the notification email for your comment there.
|
@rewitt1: Sorry, looks like gmail dropped the notification email for your comments 12 days ago so I never replied. poky-container will need updating now to include an Ubuntu 20.04 image and to enable buildtools if it's installed. |
