Clarify mergeOptions to toFieldPath migration logic
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Watts <[email protected]>
jbw976
changed the title
mergeOptions to toFieldPath migration logic
phisco
approved these changes
Apr 29, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the README to clarify and make more explicit the equivalent configuration between the no longer supported
mergeOptionsand the replacementtoFieldPath. It took a bit of effort to figure out the conversion logic incrossplane/crossplane#5464, so this PR is an attempt to update the README to make this more clear for future readers.
The paragraph form of non-exhaustive cases has been replaced by a table with all possible cases and one explicit example has been included to. Hopefully this new approach is more readable and understandable for folks 🙏