parse job events to extract failure messages #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Follow-up for #228
In #294, we set the
Ready
condition, but the message on the condition was just the ansible-runner's exit code.In this PR, the message is enhanced with the failure reason(s) from ansible logs.
Btw, parsing these job events can also help with #290 - there's a "summary" event at the end of playbook execution wich has the same info as ansible summary in the logs
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Created an ansiblerun with a failure, an unreachable host, and successful execution.
Here are examples of the conditions of the failed ones: