Skip to content

Commit

Permalink
Merge pull request #1750 from wotolom/dbinstance-deletautobackup-upda…
Browse files Browse the repository at this point in the history
…teloop-fix

fix(dbinstance): remove DeleteAutomatedBackups from isUpToDate-check
  • Loading branch information
Christopher Haar authored May 4, 2023
2 parents b4039cc + c564914 commit 37542c0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/controller/rds/dbinstance/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ func (e *custom) isUpToDate(cr *svcapitypes.DBInstance, out *svcsdk.DescribeDBIn
// This could be matured a bit more for specific statuses, such as not allowing storage changes
// when the status is "storage-optimization"
status := aws.StringValue(out.DBInstances[0].DBInstanceStatus)
if status == "modifying" || status == "upgrading" || status == "rebooting" || status == "creating" {
if status == "modifying" || status == "upgrading" || status == "rebooting" || status == "creating" || status == "deleting" {
return true, nil
}

Expand Down Expand Up @@ -412,6 +412,7 @@ func (e *custom) isUpToDate(cr *svcapitypes.DBInstance, out *svcsdk.DescribeDBIn
cmpopts.IgnoreFields(svcapitypes.CustomDBInstanceParameters{}, "ApplyImmediately"),
cmpopts.IgnoreFields(svcapitypes.CustomDBInstanceParameters{}, "RestoreFrom"),
cmpopts.IgnoreFields(svcapitypes.CustomDBInstanceParameters{}, "VPCSecurityGroupIDs"),
cmpopts.IgnoreFields(svcapitypes.CustomDBInstanceParameters{}, "DeleteAutomatedBackups"),
)

if diff == "" && !maintenanceWindowChanged && !backupWindowChanged && !pwChanged && !versionChanged && !vpcSGsChanged && !dbParameterGroupChanged {
Expand Down

0 comments on commit 37542c0

Please sign in to comment.