Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecs): Fix isUpToDate diffs & missing lateInits #2122

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix(ecs): Fix isUpToDate diffs & missing lateInits #2122

merged 1 commit into from
Nov 8, 2024

Conversation

simwak
Copy link
Contributor

@simwak simwak commented Nov 8, 2024

Description of your changes

Fixes

  • tag updates
  • lateInit Diffs
  • nil pointer when resource is deleted on AWS

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Checked lateInit diffs
  • Checked what happens when AWS resource is deleted

MisterMX
MisterMX approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @simwak!

@MisterMX MisterMX merged commit 935c145 into crossplane-contrib:master Nov 8, 2024
8 of 9 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Successfully created backport PR #2124 for release-0.50.

@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
backport release-0.50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simwak @MisterMX