Merge pull request #208 from thde/thde/pull-chart-login

fix(helm): skip login if no credentials are provided
crossplane-contrib · Apr 23, 2024 · 14e578d · 14e578d
2 parents 92d23a7 + 1f970c8
commit 14e578d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/clients/helm/client.go b/pkg/clients/helm/client.go
@@ -221,9 +221,11 @@ func (hc *client) pullChart(spec *v1beta1.ChartSpec, creds *RepoCreds, chartDir
 
 	pc.DestDir = chartDir
 
-	err := hc.login(spec, creds, pc.InsecureSkipTLSverify)
-	if err != nil {
-		return err
+	if creds.Username != "" && creds.Password != "" {
+		err := hc.login(spec, creds, pc.InsecureSkipTLSverify)
+		if err != nil {
+			return err
+		}
 	}
 
 	o, err := pc.Run(chartRef)