Merge pull request #263 from crossplane-contrib/backport-262-to-relea…

…se-0.19 [Backport release-0.19] fix: remove omitempty in invalid json tag combination
crossplane-contrib · Jan 8, 2025 · 282a939 · 282a939
2 parents a9f1e23 + 9ac6295
commit 282a939
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apis/release/v1alpha1/types.go b/apis/release/v1alpha1/types.go
@@ -40,7 +40,7 @@ type NamespacedName struct {
 
 // DataKeySelector defines required spec to access a key of a configmap or secret
 type DataKeySelector struct {
-	NamespacedName `json:",inline,omitempty"`
+	NamespacedName `json:",inline"`
 	Key            string `json:"key,omitempty"`
 	Optional       bool   `json:"optional,omitempty"`
 }

diff --git a/apis/release/v1beta1/types.go b/apis/release/v1beta1/types.go
@@ -47,7 +47,7 @@ type NamespacedName struct {
 
 // DataKeySelector defines required spec to access a key of a configmap or secret
 type DataKeySelector struct {
-	NamespacedName `json:",inline,omitempty"`
+	NamespacedName `json:",inline"`
 	Key            string `json:"key,omitempty"`
 	Optional       bool   `json:"optional,omitempty"`
 }