Merge pull request #262 from kkendzia/fix/remove_invalid_json_tag

fix: remove omitempty in invalid json tag combination
crossplane-contrib · Jan 8, 2025 · f56c8c1 · f56c8c1
2 parents a9426f1 + 0d1914a
commit f56c8c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apis/release/v1alpha1/types.go b/apis/release/v1alpha1/types.go
@@ -40,7 +40,7 @@ type NamespacedName struct {
 
 // DataKeySelector defines required spec to access a key of a configmap or secret
 type DataKeySelector struct {
-	NamespacedName `json:",inline,omitempty"`
+	NamespacedName `json:",inline"`
 	Key            string `json:"key,omitempty"`
 	Optional       bool   `json:"optional,omitempty"`
 }

diff --git a/apis/release/v1beta1/types.go b/apis/release/v1beta1/types.go
@@ -47,7 +47,7 @@ type NamespacedName struct {
 
 // DataKeySelector defines required spec to access a key of a configmap or secret
 type DataKeySelector struct {
-	NamespacedName `json:",inline,omitempty"`
+	NamespacedName `json:",inline"`
 	Key            string `json:"key,omitempty"`
 	Optional       bool   `json:"optional,omitempty"`
 }