Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable MaxConcurrentReconciles with a better default for max-reconcile-rate #211

Merged
merged 5 commits into from
Feb 20, 2024
+44 −249
Merged

Configurable MaxConcurrentReconciles with a better default for max-reconcile-rate #211

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5771d0b
Use better defaults for poll interval and max reconcile rate
turkenh Feb 19, 2024
ffdc25e
Bump runtime to v1.14.4
turkenh Feb 20, 2024
ef80a20
Bump build submodule to latest
turkenh Feb 20, 2024
ec239f6
Use uptest for e2e testing
turkenh Feb 20, 2024
5c78a46
Use uptest for e2e testing
turkenh Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions cmd/provider/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ import (
template "github.com/crossplane-contrib/provider-helm/pkg/controller"
)

const (
maxConcurrency = 10
)

func main() {
var (
app = kingpin.New(filepath.Base(os.Args[0]), "Helm support for Crossplane.").DefaultEnvars()
Expand All @@ -53,7 +49,7 @@ func main() {
timeout = app.Flag("timeout", "Controls how long helm commands may run before they are killed.").Default("10m").Duration()
syncInterval = app.Flag("sync", "How often all resources will be double-checked for drift from the desired state.").Short('s').Default("1h").Duration()
pollInterval = app.Flag("poll", "How often individual resources will be checked for drift from the desired state").Default("10m").Duration()
maxReconcileRate = app.Flag("max-reconcile-rate", "The global maximum rate per second at which resources may checked for drift from the desired state.").Default("10").Int()
maxReconcileRate = app.Flag("max-reconcile-rate", "The global maximum rate per second at which resources may checked for drift from the desired state.").Default("100").Int()
)
kingpin.MustParse(app.Parse(os.Args[1:]))

Expand Down Expand Up @@ -94,7 +90,7 @@ func main() {
kingpin.FatalIfError(apis.AddToScheme(mgr.GetScheme()), "Cannot add Helm APIs to scheme")
o := controller.Options{
Logger: log,
MaxConcurrentReconciles: maxConcurrency,
MaxConcurrentReconciles: *maxReconcileRate,
PollInterval: *pollInterval,
GlobalRateLimiter: ratelimiter.NewGlobal(*maxReconcileRate),
Features: &feature.Flags{},
Expand Down
Loading