Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SSO examples uptestable #1350

Closed

Conversation

mbbush
Copy link
Collaborator

@mbbush mbbush commented Jun 10, 2024

Description of your changes

I noticed when doing #1349 that some of the ssoadmin resources have an external name configuration that uses index to extract a value that appears in a singleton object. These seemed like good candidates to test with these changes.

I'm pleased to report that ✔️ the tests pass with no issues for all the v1beta1 and v1beta2 manifests in both identitystore and ssoadmin. Logs are attached. Note that because I deliberately used unique names for each resource when I first wrote these example manifests, I was able to uptest them all at once (per api version), which was quite fast.

I also made the ssoadmin and identitystore resources uptestable by using an uptest datasource.

In order for these to pass with the config used in github actions, someone from upbound will need to:

  • Create an instance of aws iam identity center in us-east-1 in the aws organization the uptest account belongs to. If it's not in an organization, then it can just be made into an org (I did this with my personal account)
  • If the uptest account is not the primary account for its aws organization, then it needs to be made a delegated admin account in the IAM identity Center console.
  • Put the appropriate values in the github secret used for the uptest datasource.

Note on aws terminology: IAM Identiy Center is the current name for what aws originally launched as "sso" and "identity store". We still have the old names in the SDK, but the console uses the new marketing names.

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

ssoadmin-v1beta1.logs.txt
ssoadmin-v1beta2.logs.txt
identitystore.logs.txt

@mbbush mbbush changed the title Matt/sso examples uptestable Make SSO examples uptestable for embedded object change Jun 10, 2024
@mbbush mbbush marked this pull request as ready for review June 10, 2024 01:24
@mbbush mbbush force-pushed the matt/sso-examples-uptestable branch from 77e869d to e01f4af Compare June 18, 2024 23:28
@mbbush mbbush changed the title Make SSO examples uptestable for embedded object change Make SSO examples uptestable Jun 18, 2024
@turkenf
Copy link
Collaborator

turkenf commented Jun 24, 2024

/test-examples="examples/identitystore/v1beta1/group.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jun 24, 2024

/test-examples="examples/ssoadmin/v1beta1/permissionset.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jun 24, 2024

Thanks for this PR @mbbush,

I added values ​​for identity_store_id and sso_instance_arn to the data source but I'm not sure if the test account is authorized or not.

Copy link

This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Sep 23, 2024
Copy link

github-actions bot commented Oct 7, 2024

This pull request is being closed since there has been no activity for 14 days since marking it as stale. If you're still working on this, feel free to reopen the PR or create a new one!

@github-actions github-actions bot closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants