Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I noticed when doing #1349 that some of the ssoadmin resources have an external name configuration that uses
index
to extract a value that appears in a singleton object. These seemed like good candidates to test with these changes.I'm pleased to report that ✔️ the tests pass with no issues for all the v1beta1 and v1beta2 manifests in both identitystore and ssoadmin. Logs are attached. Note that because I deliberately used unique names for each resource when I first wrote these example manifests, I was able to uptest them all at once (per api version), which was quite fast.
I also made the ssoadmin and identitystore resources uptestable by using an uptest datasource.
In order for these to pass with the config used in github actions, someone from upbound will need to:
Note on aws terminology: IAM Identiy Center is the current name for what aws originally launched as "sso" and "identity store". We still have the old names in the SDK, but the console uses the new marketing names.
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
ssoadmin-v1beta1.logs.txt
ssoadmin-v1beta2.logs.txt
identitystore.logs.txt