Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual intervention annotation from dbformysql.Server example #93

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Dec 19, 2022

Description of your changes

Removes the manual-intervention annotation from the example manifest examples/dbformysql/server.yaml.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Uptest: https://github.com/upbound/provider-azure/actions/runs/3733759987

@ulucinar
Copy link
Collaborator Author

/test-examples="examples/dbformysql/server.yaml"

@ulucinar
Copy link
Collaborator Author

/test-examples="examples/dbformysql/server.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar
Copy link
Collaborator Author

ulucinar commented Dec 20, 2022

Thanks @sergenyalcin. I believe password generation deserves its own templating support in upest. Will open an issue about this:
upbound/official-providers-ci#56

@ulucinar ulucinar merged commit b53e573 into crossplane-contrib:main Dec 20, 2022
@ulucinar ulucinar deleted the automate-server branch December 20, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants