Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken link #782

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: broken link #782

merged 1 commit into from
Jun 5, 2024

Conversation

joachimprinzbach
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit ec94f1d
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/66606b7015f8010008e6bda9
😎 Deploy Preview https://deploy-preview-782--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 6 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for taking the time to make this update @joachimprinzbach! It's functionally correct, but just one request for you to make this same change to the v1.16 directory too 🙇‍♂️

@@ -332,7 +332,7 @@ Below are vendors providing conformant Crossplane distributions.
#### Upbound
Upbound, the founders of Crossplane, maintains a free and open source
distribution of Crossplane called
[Universal Crossplane](https://www.upbound.io/products/universal-crossplane)
[Universal Crossplane](https://www.upbound.io/product/universal-crossplane)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change looks correct to me now and is working on the preview site. nice find!

can you also make this same change to https://github.com/crossplane/docs/blob/master/content/v1.16/software/install.md, so folks will see your update right away on the latest (i.e. v1.16) version of the site? 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included the fix in all the versions

@jbw976
Copy link
Member

jbw976 commented Jun 4, 2024

I think your commit may also need a DCO sign-off, which can be easily updated with these instructions: https://github.com/crossplane/crossplane/tree/master/contributing#certificate-of-origin

Signed-off-by: Joachim Prinzbach <[email protected]>
@joachimprinzbach
Copy link
Contributor Author

I think your commit may also need a DCO sign-off, which can be easily updated with these instructions: https://github.com/crossplane/crossplane/tree/master/contributing#certificate-of-origin

Yeah thanks for pointing out - commit is signed now

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @joachimprinzbach, thank you for backporting this fix to previous versions as well! 💪

@jbw976 jbw976 merged commit dda19d8 into crossplane:master Jun 5, 2024
6 checks passed
@joachimprinzbach joachimprinzbach deleted the patch-1 branch June 6, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants