Fix: bttv wide emote #2178
Merged
Fix: bttv wide emote #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix BTTV wide emotes not all emotes are fixed width
Rather then trying to calculate the width of the image Unsetting it seemed like the better Fix.
if anyone can see a better way to handle this i will gladly change to it
i did check the message.part.emote to see if a size or width was sent and it is not
this was only applied to the BTTV Emotes More testing would be needed for the rest of the 3rd party emote venders.
Applicable Issues
#2119
Testing
used emotes with text in chat
Screenshots
before
after