-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (vars): Add $pollTitle and $pollChoices Variables #2777
Open
phroggster
wants to merge
10
commits into
crowbartools:v5
Choose a base branch
from
phroggster:poll_vaulting
base: v5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 1, 2024
-
feat: Add $pollChoices and $pollTitle variables
- $pollChoices provides for just about every imaginable piece of info about polling options for Poll Started, Poll Progress, and Poll Ended events. - Meanwhile, $pollTitle is a bit more focused for just the title of a poll. - Fix mismatched metadata for the poll-progress and poll-end events. - Implements the remaining bits of crowbartools#2732
Configuration menu - View commit details
-
Copy full SHA for bd811b9 - Browse repository at this point
Copy the full SHA bd811b9View commit details -
Fix poll start metadata, and pollChoices description
- and add manual triggering to $pollChoices
Configuration menu - View commit details
-
Copy full SHA for 096f728 - Browse repository at this point
Copy the full SHA 096f728View commit details
Commits on Sep 2, 2024
-
- "title" is a valid propertySelector. - Ignore an empty string (or anything falsy) as a propertySelector. - Better commentary
Configuration menu - View commit details
-
Copy full SHA for 22d0e3e - Browse repository at this point
Copy the full SHA 22d0e3eView commit details -
- Include choice IDs in raw object returns (raw or null property selector). - Simulate more realistic IDs in polling event metadata.
Configuration menu - View commit details
-
Copy full SHA for 79caa39 - Browse repository at this point
Copy the full SHA 79caa39View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9454c5a - Browse repository at this point
Copy the full SHA 9454c5aView commit details -
Merge pull request #1 from CKY-/poll_vaulting
Add simulate event controls to $pollChoices. Thanks CK!
Configuration menu - View commit details
-
Copy full SHA for 8c656fe - Browse repository at this point
Copy the full SHA 8c656feView commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f814748 - Browse repository at this point
Copy the full SHA f814748View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 06047c8 - Browse repository at this point
Copy the full SHA 06047c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54167e2 - Browse repository at this point
Copy the full SHA 54167e2View commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 39eeae4 - Browse repository at this point
Copy the full SHA 39eeae4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.