Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): complex manualMetadata being malformed on test event button #2784

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

CKY-
Copy link
Collaborator

@CKY- CKY- commented Sep 6, 2024

Description of the Change

complex manualMetadata eg:

       manualMetadata: {
           title: "Poll name"
           choices: {
                type: "choice-list",
                value:[
                { id: "c0113c14-144e-475c-9647-a65f9177665d", title: "Test Choice 1" },
                { id: "6d86797a-d88a-4fc2-b4f6-1895afdc503e", title: "Test Choice 2" },
                { id: "791bc06c-c4d5-4c74-b950-8596c04dbb0d", title: "Test Choice 3" }
            ]
           }
        }

being malformed on test event button
this would cause variable data to return the variable name.

Applicable Issues

#2783

Testing

made many events that leverage Enum and arbitrary data structs to see what the variable data would return in the console log
1000 Test message

Firebot,User1, User2, User3, User4, User5,

[{"id":"c0113c14-144e-475c-9647-a65f9177665d","index":1,"title":"Test Choice 1","points":62,"votes":125},{"id":"6d86797a-d88a-4fc2-b4f6-1895afdc503e","index":2,"title":"Test Choice 2","points":42,"votes":145},{"id":"791bc06c-c4d5-4c74-b950-8596c04dbb0d","index":3,"title":"Test Choice 3","points":72,"votes":85}]

Screenshots

@ebiggz ebiggz merged commit 9ac36a0 into crowbartools:v5 Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants