Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: $hasRole and $hasRoles Usage Examples #2790

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

phroggster
Copy link
Collaborator

@phroggster phroggster commented Sep 7, 2024

Description of the Change

Fixes usage examples for $hasRoles and adds examples for $hasRole.

  • Role name comparisons are case-sensitive.
  • Moderator and VIP being the actual names from Twitch.
  • So reflect those accurately in the examples.
  • ... and clear up a few lint warnings (white space, ignored params)

Applicable Issues

Discord #questions thread: give VIP or Mod role based on metadata?

Testing

Minimal

Screenshots

hasRoles

- Role name comparisons are case-sensitive.
- Moderator and VIP being the names sent out.
- So reflect those accurately in the examples.
- ... and clear up a few lint warnings (white space, ignored param)
Copy link
Member

@ebiggz ebiggz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow nice find on the incorrect usages. Looks good 🥇

@ebiggz ebiggz enabled auto-merge (squash) September 13, 2024 02:54
@ebiggz ebiggz merged commit d4a276e into crowbartools:v5 Sep 13, 2024
1 check passed
@phroggster phroggster deleted the has_role_improvements branch September 13, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants