Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Show expected category when command fails due to category/game filter #2795

Merged

Conversation

Oceanity
Copy link
Contributor

@Oceanity Oceanity commented Sep 9, 2024

Description of the Change

This change simply modifies the set-in-stone "Channel category/game isn't set to the correct category/game" response with one that attempts to pull the correct name from the Twitch API to be more specific/helpful, and will fall back to the other if the API doesn't find anything

Applicable Issues

N/A, just noticed it while working on Firebot stuff and figured it'd be quick enough to knock out 😛

Testing

Tested failed command due to category/game filter with expected output

Screenshots

N/A

Copy link
Member

@CaveMobster CaveMobster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, nice addition!

@CaveMobster CaveMobster merged commit b88396e into crowbartools:v5 Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants