-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Offline Currency Payout Improvements #2797
Open
phroggster
wants to merge
11
commits into
crowbartools:v5
Choose a base branch
from
phroggster:currency_payouts
base: v5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Sep 10, 2024
-
fix: Offline Currency Payout Improvement
- Currency payouts would stop paying out while offline once any currency had a zero offline payout. - Changed it to keep checking additional currencies. - Issue crowbartools#2796
Configuration menu - View commit details
-
Copy full SHA for d7f11ca - Browse repository at this point
Copy the full SHA d7f11caView commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 84dd4af - Browse repository at this point
Copy the full SHA 84dd4afView commit details -
fix: More Offline Currency Payout Issues
- Checking then unchecking the Offline Payout checkbox in the add or edit currency dialog results in the offline property being assigned to an empty string. - This conflicts with the type definition of a Currency in currency-access.ts. - So pay special attention to it potentially being an empty string. - See issue crowbartools#2801
Configuration menu - View commit details
-
Copy full SHA for 197fe92 - Browse repository at this point
Copy the full SHA 197fe92View commit details -
Revert "fix: More Offline Currency Payout Issues"
This reverts commit 197fe92. Going to edit the currency add/edit controller instead. It's better for everyone.
Configuration menu - View commit details
-
Copy full SHA for 1b8efce - Browse repository at this point
Copy the full SHA 1b8efceView commit details -
fix: Offline Currency Data Typing
- Checking then unchecking the offline payout option in an add or edit currency modal will assign an empty string to the data model. - The data model is typed as a Number. - This typing is exposed to external scripts. - So trim the null or empty string on addOrEditCurrency controller save to prevent a string from getting through. - See issue crowbartools#2801.
Configuration menu - View commit details
-
Copy full SHA for 6cba965 - Browse repository at this point
Copy the full SHA 6cba965View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b02996 - Browse repository at this point
Copy the full SHA 4b02996View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0633501 - Browse repository at this point
Copy the full SHA 0633501View commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 602ddd0 - Browse repository at this point
Copy the full SHA 602ddd0View commit details -
- Remove the empty string offline currency payout upon read. - Immediately re-write the file without the poorly-typed value. - Remove the empty string offline currency payout upon import, before it actually gets added or updated.
Configuration menu - View commit details
-
Copy full SHA for 48eb0ba - Browse repository at this point
Copy the full SHA 48eb0baView commit details -
- currency-access.ts should also catch nulls, while 0's are OK. - currency-manager.ts is much more concise with a boolean nullish. - As-is currency.service.js... - ... which also had two lint warnings in it that got buffed out.
Configuration menu - View commit details
-
Copy full SHA for 3735140 - Browse repository at this point
Copy the full SHA 3735140View commit details -
- addOrEditCurrency.js can also use a boolean nullish. - Buffed out the two arrow-parens lint warnings in there as well.
Configuration menu - View commit details
-
Copy full SHA for c92b960 - Browse repository at this point
Copy the full SHA c92b960View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.