Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Offline Currency Payout Improvements #2797

Open
wants to merge 11 commits into
base: v5
Choose a base branch
from

Commits on Sep 10, 2024

  1. fix: Offline Currency Payout Improvement

    - Currency payouts would stop paying out while offline once any currency
      had a zero offline payout.
    - Changed it to keep checking additional currencies.
    - Issue crowbartools#2796
    phroggster committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d7f11ca View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    84dd4af View commit details
    Browse the repository at this point in the history
  2. fix: More Offline Currency Payout Issues

    - Checking then unchecking the Offline Payout checkbox in the add or
      edit currency dialog results in the offline property being assigned to
      an empty string.
    - This conflicts with the type definition of a Currency in
      currency-access.ts.
    - So pay special attention to it potentially being an empty string.
    - See issue crowbartools#2801
    phroggster committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    197fe92 View commit details
    Browse the repository at this point in the history
  3. Revert "fix: More Offline Currency Payout Issues"

    This reverts commit 197fe92.
    Going to edit the currency add/edit controller instead. It's better for
    everyone.
    phroggster committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1b8efce View commit details
    Browse the repository at this point in the history
  4. fix: Offline Currency Data Typing

    - Checking then unchecking the offline payout option in an add or edit
      currency modal will assign an empty string to the data model.
    - The data model is typed as a Number.
    - This typing is exposed to external scripts.
    - So trim the null or empty string on addOrEditCurrency controller save
      to prevent a string from getting through.
    - See issue crowbartools#2801.
    phroggster committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6cba965 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    4b02996 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0633501 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    602ddd0 View commit details
    Browse the repository at this point in the history
  2. More crowbartools#2801 Stuff

    - Remove the empty string offline currency payout upon read.
      - Immediately re-write the file without the poorly-typed value.
    - Remove the empty string offline currency payout upon import, before it
      actually gets added or updated.
    phroggster committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    48eb0ba View commit details
    Browse the repository at this point in the history
  3. Better issue2801 Conditionals

    - currency-access.ts should also catch nulls, while 0's are OK.
    - currency-manager.ts is much more concise with a boolean nullish.
    - As-is currency.service.js...
    - ... which also had two lint warnings in it that got buffed out.
    phroggster committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3735140 View commit details
    Browse the repository at this point in the history
  4. Another Conditional Cleanup

    - addOrEditCurrency.js can also use a boolean nullish.
    - Buffed out the two arrow-parens lint warnings in there as well.
    phroggster committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c92b960 View commit details
    Browse the repository at this point in the history