Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3343 + #3350 #3347

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix #3343 + #3350 #3347

wants to merge 10 commits into from

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Nov 27, 2024

Do not attempt to dedup modsec native rules as they might have no IDs. Doing this can mess up stuff (see #3350 )

Copy link

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@buixor
Copy link
Contributor Author

buixor commented Nov 27, 2024

/area agent
/kind fix

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.44%. Comparing base (ecf34c2) to head (ee349b6).

Files with missing lines Patch % Lines
pkg/appsec/appsec_rules_collection.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3347      +/-   ##
==========================================
- Coverage   58.45%   58.44%   -0.02%     
==========================================
  Files         351      351              
  Lines       37893    37895       +2     
==========================================
- Hits        22151    22147       -4     
- Misses      13835    13840       +5     
- Partials     1907     1908       +1     
Flag Coverage Δ
bats 41.24% <0.00%> (-0.06%) ⬇️
unit-linux 34.44% <50.00%> (+0.02%) ⬆️
unit-windows 29.67% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor changed the title fix #3343 fix #3343 + #3350 Nov 29, 2024
@buixor buixor added this to the 1.6.5 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants