-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add a connection test to explain to add '-no-api' flag #3385
base: master
Are you sure you want to change the base?
enhancement: add a connection test to explain to add '-no-api' flag #3385
Conversation
@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind enhancement |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3385 +/- ##
==========================================
- Coverage 58.63% 58.60% -0.03%
==========================================
Files 356 356
Lines 38215 38237 +22
==========================================
+ Hits 22406 22410 +4
- Misses 13895 13910 +15
- Partials 1914 1917 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
as outlined in #3183 you cannot run explain whilst LAPI is not available, this PR adds a connection test to explain and if the connection succeeds, the
-no-api
flag is then appended to the cmd arguments.