CI: use golangci-lint 1.61

.github/workflows/lint.yml

@@ -37,15 +37,11 @@ jobs:
         make build
 
     - name: golangci-lint
-      uses: golangci/golangci-lint-action@v4
+      uses: golangci/golangci-lint-action@v6
       with:
-        version: v1.59
+        version: v1.61
         args: --issues-exit-code=1 --timeout 10m
         only-new-issues: false
-        # the cache is already managed above, enabling it here
-        # gives errors when extracting
-        skip-pkg-cache: true
-        skip-build-cache: true
 
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@v3

.golangci.yml

@@ -103,6 +103,7 @@ linters:
     # DEPRECATED by golangi-lint
     #
     - execinquery
+    - exportloopref
 
     #
     # Redundant
@@ -119,83 +120,6 @@ linters:
     #
     - gci               # Gci control golang package import order and make it always deterministic.
 
-    #
-    # Enabled
-    #
-
-    # - asasalint           # check for pass []any as any in variadic func(...any)
-    # - asciicheck          # checks that all code identifiers does not have non-ASCII symbols in the name
-    # - bidichk             # Checks for dangerous unicode character sequences
-    # - bodyclose           # checks whether HTTP response body is closed successfully
-    # - containedctx        # containedctx is a linter that detects struct contained context.Context field
-    # - contextcheck        # check the function whether use a non-inherited context
-    # - decorder            # check declaration order and count of types, constants, variables and functions
-    # - depguard            # Go linter that checks if package imports are in a list of acceptable packages
-    # - dupword             # checks for duplicate words in the source code
-    # - durationcheck       # check for two durations multiplied together
-    # - errcheck            # errcheck is a program for checking for unchecked errors in Go code. These unchecked errors can be critical bugs in some cases
-    # - errchkjson          # Checks types passed to the json encoding functions. Reports unsupported types and optionally reports occations, where the check for the returned error can be omitted.
-    # - errname             # Checks that sentinel errors are prefixed with the `Err` and error types are suffixed with the `Error`.
-    # - errorlint           # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13.
-    # - exhaustive          # check exhaustiveness of enum switch statements
-    # - exportloopref       # checks for pointers to enclosing loop variables
-    # - forcetypeassert     # finds forced type assertions
-    # - ginkgolinter        # enforces standards of using ginkgo and gomega
-    # - gocheckcompilerdirectives # Checks that go compiler directive comments (//go:) are valid.
-    # - gochecknoinits      # Checks that no init functions are present in Go code
-    # - gochecksumtype      # Run exhaustiveness checks on Go "sum types"
-    # - gocritic            # Provides diagnostics that check for bugs, performance and style issues.
-    # - godot               # Check if comments end in a period
-    # - gofmt               # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification
-    # - goheader            # Checks is file header matches to pattern
-    # - goimports           # In addition to fixing imports, goimports also formats your code in the same style as gofmt.
-    # - gomoddirectives     # Manage the use of 'replace', 'retract', and 'excludes' directives in go.mod.
-    # - gomodguard          # Allow and block list linter for direct Go module dependencies. This is different from depguard where there are different block types for example version constraints and module recommendations.
-    # - goprintffuncname    # Checks that printf-like functions are named with `f` at the end
-    # - gosimple            # (megacheck): Linter for Go source code that specializes in simplifying a code
-    # - gosmopolitan        # Report certain i18n/l10n anti-patterns in your Go codebase
-    # - govet               # (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
-    # - grouper             # Analyze expression groups.
-    # - importas            # Enforces consistent import aliases
-    # - ineffassign         # Detects when assignments to existing variables are not used
-    # - interfacebloat      # A linter that checks the number of methods inside an interface.
-    # - loggercheck         # (logrlint): Checks key value pairs for common logger libraries (kitlog,klog,logr,zap).
-    # - logrlint            # Check logr arguments.
-    # - maintidx            # maintidx measures the maintainability index of each function.
-    # - makezero            # Finds slice declarations with non-zero initial length
-    # - mirror              # reports wrong mirror patterns of bytes/strings usage
-    # - misspell            # Finds commonly misspelled English words
-    # - nakedret            # Checks that functions with naked returns are not longer than a maximum size (can be zero).
-    # - nilerr              # Finds the code that returns nil even if it checks that the error is not nil.
-    # - nilnil              # Checks that there is no simultaneous return of `nil` error and an invalid value.
-    # - noctx               # noctx finds sending http request without context.Context
-    # - nolintlint          # Reports ill-formed or insufficient nolint directives
-    # - nonamedreturns      # Reports all named returns
-    # - nosprintfhostport   # Checks for misuse of Sprintf to construct a host with port in a URL.
-    # - perfsprint          # Checks that fmt.Sprintf can be replaced with a faster alternative.
-    # - prealloc            # Finds slice declarations that could potentially be preallocated
-    # - predeclared         # find code that shadows one of Go's predeclared identifiers
-    # - promlinter          # Check Prometheus metrics naming via promlint
-    # - reassign            # Checks that package variables are not reassigned
-    # - revive              # Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint.
-    # - rowserrcheck        # checks whether Err of rows is checked successfully
-    # - sloglint            # ensure consistent code style when using log/slog
-    # - spancheck           # Checks for mistakes with OpenTelemetry/Census spans.
-    # - sqlclosecheck       # Checks that sql.Rows, sql.Stmt, sqlx.NamedStmt, pgx.Query are closed.
-    # - staticcheck         # (megacheck): It's a set of rules from staticcheck. It's not the same thing as the staticcheck binary. The author of staticcheck doesn't support or approve the use of staticcheck as a library inside golangci-lint.
-    # - stylecheck          # Stylecheck is a replacement for golint
-    # - tenv                # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17
-    # - testableexamples    # linter checks if examples are testable (have an expected output)
-    # - testifylint         # Checks usage of github.com/stretchr/testify.
-    # - thelper             # thelper detects golang test helpers without t.Helper() call and checks the consistency of test helpers
-    # - tparallel           # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes
-    # - typecheck           # Like the front-end of a Go compiler, parses and type-checks Go code
-    # - unconvert           # Remove unnecessary type conversions
-    # - unused              # (megacheck): Checks Go code for unused constants, variables, functions and types
-    # - usestdlibvars       # A linter that detect the possibility to use variables/constants from the Go standard library.
-    # - wastedassign        # Finds wasted assignment statements
-    # - zerologlint         # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg`
-
     #
     # Recommended? (easy)
     #