Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: apply variable expansion to all keys #364

Merged
merged 3 commits into from
Mar 11, 2024
Merged

config: apply variable expansion to all keys #364

merged 3 commits into from
Mar 11, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Mar 11, 2024

No description provided.

@mmetc mmetc added this to the 0.0.29 milestone Mar 11, 2024
@mmetc mmetc changed the title config: fix variable expansion config: apply variable expansion to all keys Mar 11, 2024
sabban
sabban approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 0d19a68 into main Mar 11, 2024
5 checks passed
@mmetc mmetc deleted the expand-envvar branch March 11, 2024 13:11
@kampka
Copy link

kampka commented Mar 11, 2024

Thanks, @sabban @mmetc , I highly appreciate it. The week is a bit swamped, but I'll try to get back to you with feedback on 0.0.29 by weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabban sabban sabban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.29
Development

Successfully merging this pull request may close these issues.
3 participants
@mmetc @kampka @sabban