add metrics ability to the lua bouncer #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add metrics
* in some case allow sending 0 value processed request
* get rid of METRICS_PERIOD configuration item. It's now 300.
…r into tests/stream
AlteredCoder
requested changes
Dec 20, 2024
| ngx.log(ngx.INFO, "no labels") | ||
| end | ||
|
|
||
| key = key .. "/" .. utils.table_to_string(labels) |
There was a problem hiding this comment.
is it possible to show in a comment what a key look like please?
| for _, key in ipairs(keys) do | ||
| if utils.starts_with(key, "decision_cache/") then | ||
| local decision_string = stream.cache:get(key) | ||
| local t = utils.split_on_delimiter(decision_string,"/") |
There was a problem hiding this comment.
can you show in a comment what are different part of the decision, else it is a mess to understand the rest of the code
| ngx.log(ngx.DEBUG, "timer started: " .. tostring(runtime.timer_started) .. " in worker " .. tostring(ngx.worker.id())) | ||
| if runtime.timer_started == false and runtime.conf["MODE"] == "stream" then |
There was a problem hiding this comment.
why did the check on "stream" mode has been removed?
There was a problem hiding this comment.
It has not been removed you will find it in:
if runtime.conf["MODE"] == "stream" then
ngx.log(ngx.INFO, "stream mode")
SetupStream()
end
The metrics code doesn't depend on mode, so that's why it is not ran under a check with stream mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, further tests are needed, especially for captcha
Updates: