Allow timescale to be a non-primary rails db #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
commented
Apr 3, 2023
lib/timescaledb/rails/extensions/active_record/schema_dumper.rb
Outdated
Show resolved
Hide resolved
lib/timescaledb/rails/extensions/active_record/schema_dumper.rb
Outdated
Show resolved
Hide resolved
lib/timescaledb/rails/extensions/active_record/schema_dumper.rb
Outdated
Show resolved
Hide resolved
lib/timescaledb/rails/extensions/active_record/schema_dumper.rb
Outdated
Show resolved
Hide resolved
lib/timescaledb/rails/extensions/active_record/schema_dumper.rb
Outdated
Show resolved
Hide resolved
lib/timescaledb/rails/extensions/active_record/schema_dumper.rb
Outdated
Show resolved
Hide resolved
|
@segiddins Thank you so much for your contribution, it's awesome to hear that rubygems will use the gem 🚀 |
segiddins
force-pushed
the
segiddins/support-for-timescale-in-other-database
branch
from
758fdee
to
14432de
Compare
lib/timescaledb/rails/extensions/active_record/postgresql_database_tasks.rb
Outdated
Show resolved
Hide resolved
|
@segiddins One last thing, could you follow conventional commits specs -> https://github.com/crunchloop/timescaledb-rails/blob/main/CONTRIBUTING.md#pull-requests? |
|
@santiagodoldan feel free to change the commit message when squash-merging |
|
@segiddins Sure, that works too, let me know about my last 2 comments and I will approve your PR when they are done, I'll push a new version to rubygems if everything works as expected 🚀 |
lib/timescaledb/rails/extensions/active_record/schema_dumper.rb
Outdated
Show resolved
Hide resolved
|
@segiddins Hey, let me know if my comments make sense to you, so I can resolve them and merge your changes 🚀 |
|
@segiddins Looks like |
santiagodoldan
approved these changes
Apr 19, 2023
|
@segiddins Thanks for your contribution 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables rubygems.org to use timescale as a secondary db only for gem downloads: rubygems/rfcs#48
Consumed in rubygems/rubygems.org#3560