Skip to content

Commit

Permalink
refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
@andrewazores
andrewazores committed Jul 5, 2023
1 parent 5868088 commit 92a4e21
Showing 1 changed file with 62 additions and 71 deletions.
133 changes: 62 additions & 71 deletions src/main/java/io/cryostat/agent/remote/RecordingsContext.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
import io.cryostat.core.templates.MutableTemplateService.InvalidXmlException;
import io.cryostat.core.templates.RemoteTemplateService;
import io.cryostat.core.templates.Template;
import io.cryostat.core.templates.TemplateService;
import io.cryostat.core.templates.TemplateType;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.sun.net.httpserver.HttpExchange;
Expand Down Expand Up @@ -127,77 +127,20 @@ public void handle(HttpExchange exchange) throws IOException {
exchange.sendResponseHeaders(HttpStatus.SC_BAD_REQUEST, -1);
return;
}
JFRConnection conn =
jfrConnectionToolkit.connect(
jfrConnectionToolkit.createServiceURL("localhost", 0));
TemplateService templates = null;
Template template = null;
IConstrainedMap<EventOptionID> events;
try {
if (req.requestsCustomTemplate()) {
templates = localStorageTemplateService;
template =
((LocalStorageTemplateService) templates)
.addTemplate(
new ByteArrayInputStream(
req.template.getBytes(
StandardCharsets.UTF_8)));
} else {
templates = new RemoteTemplateService(conn);
template =
templates.getTemplates().stream()
.filter(
t ->
t.getName()
.equals(
req.localTemplateName))
.findFirst()
.orElseThrow();
}
events = templates.getEvents(template).orElseThrow();
IFlightRecorderService svc = conn.getService();
SerializableRecordingDescriptor recording =
new SerializableRecordingDescriptor(
svc.start(
new RecordingOptionsBuilder(conn.getService())
.name(req.name)
.duration(
UnitLookup.MILLISECOND.quantity(
req.duration))
.maxSize(
UnitLookup.BYTE.quantity(
req.maxSize))
.maxAge(
UnitLookup.MILLISECOND.quantity(
req.maxAge))
.toDisk(true)
.build(),
events));
exchange.sendResponseHeaders(HttpStatus.SC_CREATED, 0);
try (OutputStream response = exchange.getResponseBody()) {
mapper.writeValue(response, recording);
}
} catch (QuantityConversionException
| ServiceNotAvailableException
| FlightRecorderException
| org.openjdk.jmc.rjmx.services.jfr.FlightRecorderException
| InvalidEventTemplateException
| InvalidXmlException e) {
log.error("Failed to start recording", e);
exchange.sendResponseHeaders(HttpStatus.SC_INTERNAL_SERVER_ERROR, -1);
} finally {
if (templates != null
&& template != null
&& req.requestsCustomTemplate()) {
try {
((LocalStorageTemplateService) templates)
.deleteTemplate(template);
} catch (InvalidEventTemplateException e) {
log.error(
"Failed to clean up template " + template.getName(), e);
}
}
SerializableRecordingDescriptor recording = startRecording(req);
exchange.sendResponseHeaders(HttpStatus.SC_CREATED, 0);
try (OutputStream response = exchange.getResponseBody()) {
mapper.writeValue(response, recording);
}
} catch (QuantityConversionException
| ServiceNotAvailableException
| FlightRecorderException
| org.openjdk.jmc.rjmx.services.jfr.FlightRecorderException
| InvalidEventTemplateException
| InvalidXmlException
| IOException e) {
log.error("Failed to start recording", e);
exchange.sendResponseHeaders(HttpStatus.SC_INTERNAL_SERVER_ERROR, -1);
}
break;
default:
Expand Down Expand Up @@ -230,6 +173,54 @@ private List<SerializableRecordingDescriptor> getRecordings() {
.collect(Collectors.toList());
}

private SerializableRecordingDescriptor startRecording(StartRecordingRequest req)
throws QuantityConversionException, ServiceNotAvailableException,
FlightRecorderException,
org.openjdk.jmc.rjmx.services.jfr.FlightRecorderException,
InvalidEventTemplateException, InvalidXmlException, IOException {
Runnable cleanup = () -> {};
try {
JFRConnection conn =
jfrConnectionToolkit.connect(
jfrConnectionToolkit.createServiceURL("localhost", 0));
IConstrainedMap<EventOptionID> events;
if (req.requestsCustomTemplate()) {
Template template =
localStorageTemplateService.addTemplate(
new ByteArrayInputStream(
req.template.getBytes(StandardCharsets.UTF_8)));
events = localStorageTemplateService.getEvents(template).orElseThrow();
cleanup =
() -> {
try {
localStorageTemplateService.deleteTemplate(template);
} catch (InvalidEventTemplateException | IOException e) {
log.error("Failed to clean up template " + template.getName(), e);
}
};
} else {
events =
new RemoteTemplateService(conn)
.getEvents(req.localTemplateName, TemplateType.TARGET).stream()
.findFirst()
.orElseThrow();
}
IFlightRecorderService svc = conn.getService();
return new SerializableRecordingDescriptor(
svc.start(
new RecordingOptionsBuilder(conn.getService())
.name(req.name)
.duration(UnitLookup.MILLISECOND.quantity(req.duration))
.maxSize(UnitLookup.BYTE.quantity(req.maxSize))
.maxAge(UnitLookup.MILLISECOND.quantity(req.maxAge))
.toDisk(true)
.build(),
events));
} finally {
cleanup.run();
}
}

static class StartRecordingRequest {

public String name;
Expand Down

0 comments on commit 92a4e21

Please sign in to comment.