fixup! fixup! ensure recording dumps to exit path

cryostatio · Oct 3, 2023 · e3c7d7a · e3c7d7a
1 parent 21f05da
commit e3c7d7a
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/src/main/java/io/cryostat/agent/harvest/Harvester.java b/src/main/java/io/cryostat/agent/harvest/Harvester.java
@@ -219,33 +219,28 @@ public void recordingStateChanged(Recording recording) {
                                 case STOPPED:
                                     try {
                                         tr.getRecording().dump(exitPaths.get(tr));
+                                        uploadRecording(tr).get();
                                     } catch (IOException e) {
                                         log.error("Failed to dump recording to file", e);
+                                    } catch (InterruptedException | ExecutionException e) {
+                                        log.warn("Could not upload exit dump file", e);
                                     }
                                     if (isSownRecording) {
-                                        recording.close();
+                                        safeCloseCurrentRecording();
                                     }
                                     // next
                                     break;
                                 case CLOSED:
                                     executor.submit(
                                             () -> {
-                                                if (isSownRecording) {
-                                                    safeCloseCurrentRecording();
-                                                }
                                                 if (running) {
                                                     try {
                                                         Path exitPath = exitPaths.remove(tr);
                                                         recordings.remove(tr);
-                                                        uploadRecording(tr).get();
                                                         Files.deleteIfExists(exitPath);
                                                         log.trace("Deleted temp file {}", exitPath);
-                                                    } catch (ExecutionException
-                                                            | InterruptedException
-                                                            | IOException e) {
-                                                        log.warn(
-                                                                "Could not upload exit dump file",
-                                                                e);
+                                                    } catch (IOException e) {
+                                                        log.warn("Could not delete temp file", e);
                                                     } finally {
                                                         startRecording(false);
                                                     }