feat(api): implement GET /recordings/:id for streaming files #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
http-recording-stream
branch
2 times, most recently
from
9f51122
to
6cd3c50
Compare
4 tasks
andrewazores
force-pushed
the
http-recording-stream
branch
from
6cd3c50
to
edde5af
Compare
7 tasks
andrewazores
changed the base branch from
main
to
124-epic-two-way-communications-protocol
andrewazores
force-pushed
the
http-recording-stream
branch
from
edde5af
to
abcb2b9
Compare
mwangggg
reviewed
Aug 14, 2023
mwangggg
approved these changes
Aug 14, 2023
andrewazores
merged commit 7c80d6c
into
cryostatio:124-epic-two-way-communications-protocol
6 checks passed
mwangggg
pushed a commit
to mwangggg/cryostat-agent
that referenced
this pull request
Aug 16, 2023
…tio#179) * use longs for IDs * feat(api): implement GET /recordings/:id for streaming files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #176
Fixes #178