Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(registration): discovery plugin registration bugfixes and refactor #193

Merged
merged 4 commits into from
Sep 13, 2023
Merged

fix(registration): discovery plugin registration bugfixes and refactor #193

merged 4 commits into from
Sep 13, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Sep 1, 2023 •
edited
Loading

@mergify mergify bot added the safe-to-test label Sep 1, 2023
@andrewazores andrewazores mentioned this pull request Sep 1, 2023
Merged
7 tasks
@andrewazores andrewazores marked this pull request as ready for review September 5, 2023 18:08
@andrewazores andrewazores marked this pull request as draft September 8, 2023 17:07
@andrewazores andrewazores marked this pull request as ready for review September 8, 2023 18:04
mwangggg
mwangggg approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aali309
aali309 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well

@andrewazores andrewazores merged commit 8db9b4c into cryostatio:main Sep 13, 2023
9 checks passed
@andrewazores andrewazores deleted the gh1633 branch September 13, 2023 13:53
@andrewazores andrewazores mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwangggg mwangggg mwangggg approved these changes

@aali309 aali309 aali309 approved these changes

Assignees
No one assigned
Labels
fix safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewazores @aali309 @mwangggg