feat(triggers): allow specification of triggers using SmallRye Config properties #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #217 #197 #128
This adds handling of a new config property to allow users to specify Smart Triggers by JVM system property or environment variable in addition to the previous Agent arguments method. This is useful for cases where it may be easier to add environment variables to the target application deployment than to modify the startup script to both add an Agent and append arguments for it. For example, in my typical
vertx-fib-demo
sample application, the gradle/jib build setup also uses an additional plugin for downloading, packaging, and configuring the Agent, but it doesn't (easily) allow for adding an argument to the Agent. This is probably a pretty rare corner case, as I would expect most users who are able to add the-javaagent
flag are also able to add the argument after it, but this adds extra flexibility just in case.