fix(triggers): improve whitespace handling #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
trigger-tests
branch
from
9bd72d6
to
0c21307
Compare
Josh-Matsuoka
approved these changes
Nov 27, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
(cherry picked from commit 1abcb01)
andrewazores
added a commit
that referenced
this pull request
Nov 27, 2023
(cherry picked from commit 1abcb01) Co-authored-by: Andrew Azores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #225
This PR improves whitespace handling during processing of Smart Triggers. It adds optional whitespace to the trigger grammar, and then removes all whitespaces during processing for consistency. I also added a small suite of unit tests to check this.