Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(semver): handle unparseable version strings by returning UNKNOWN instead of throwing #515

Merged
merged 3 commits into from
Oct 17, 2024
Merged

fix(semver): handle unparseable version strings by returning UNKNOWN instead of throwing #515

merged 3 commits into from
Oct 17, 2024

Conversation

andrewazores
Copy link
Member

Fixes #514

@andrewazores andrewazores marked this pull request as ready for review October 17, 2024 14:23
@andrewazores andrewazores requested a review from a team October 17, 2024 14:23
@andrewazores andrewazores merged commit 52eda9b into cryostatio:main Oct 17, 2024
9 checks passed
@andrewazores andrewazores deleted the buildinfo-nfe branch October 17, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
fix safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Build info semver parsing fails on -SNAPSHOTs
2 participants
@andrewazores @ebaron