Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Include semver major number in resource names #200

Closed
andrewazores opened this issue Sep 23, 2024 · 2 comments
Closed

[Request] Include semver major number in resource names #200

andrewazores opened this issue Sep 23, 2024 · 2 comments
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere feat New feature or request

Comments

@andrewazores
Copy link
Member

          This is just another temporary/one-time workaround the same as `--force` IMO, because we would have to do another rename again in the future if we change the labels again or do anything else similar.

Maybe a naming scheme like {{ include "cryostat.fullname" . }}-v{{ cryostat.semver.major }}, which would expand out to ex. cryostat-v3, could be usable across the various resources. This way their names stay stable within a major release version, but on major version upgrade when things are expected to change in a breaking way anyway, then the resources are renamed and upgrades can be done without force.

Originally posted by @andrewazores in #197 (comment)

@andrewazores andrewazores added feat New feature or request breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere labels Sep 23, 2024
@tthvo
Copy link
Member

tthvo commented Sep 24, 2024

@andrewazores
Copy link
Member Author

Done in #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere feat New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants