feat(template): add major version suffix to deployment names #202
+16
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #200
Related to #192
Description of changes
Added a major version suffix to deployment such that breaking changes can recreate the deployment (i.e. selector changes)
Notes
I stopped short of doing the same for other resources since they might introduce more breaking behaviors than intended. Also, resources such as secrets and configmaps can (i think) still be reused from 3.x version for seamless upgrades :D
The CI runs on this PR do not actually reflect these changes (i.e. no immutable fields are updated). We will need to manually run the steps below to check :D
How to test
Manual upgrade tests
With chart-testing