Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): add major version suffix to deployment names #202

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 24, 2024

Related to #200
Related to #192

Description of changes

Added a major version suffix to deployment such that breaking changes can recreate the deployment (i.e. selector changes)

Notes

I stopped short of doing the same for other resources since they might introduce more breaking behaviors than intended. Also, resources such as secrets and configmaps can (i think) still be reused from 3.x version for seamless upgrades :D

The CI runs on this PR do not actually reflect these changes (i.e. no immutable fields are updated). We will need to manually run the steps below to check :D

How to test

Manual upgrade tests

$ helm search repo cryostat
NAME               	CHART VERSION	APP VERSION	DESCRIPTION                                       
cryostatio/cryostat	1.0.1        	3.0.1      	Securely manage JFR recordings for your contain...

# Install 1.0.1 version
$ helm install cryostat-sample cryostatio/cryostat

# on this PR, upgrade 2.0.0-dev version
# This should now succeed without any errors
$ helm upgrade cryostat-sample charts/cryostat/

$ helm history cryostat-sample 
REVISION	UPDATED                 	STATUS    	CHART             	APP VERSION	DESCRIPTION     
1       	Tue Sep 24 13:37:42 2024	superseded	cryostat-1.0.1    	3.0.1      	Install complete
2       	Tue Sep 24 13:38:22 2024	deployed  	cryostat-2.0.0-dev	4.0.0-dev  	Upgrade complete

With chart-testing

# This will install/upgrade and run helm tests
bash ct.bash --upgrade

@tthvo tthvo added feat New feature or request chore Refactor, rename, cleanup, etc. safe-to-test labels Sep 24, 2024
@tthvo tthvo marked this pull request as ready for review September 24, 2024 20:41
@tthvo tthvo requested a review from a team September 24, 2024 20:41
@andrewazores andrewazores merged commit ddf87d5 into cryostatio:separate-db-storage Sep 25, 2024
5 checks passed
@tthvo tthvo deleted the resource-name branch September 25, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. feat New feature or request safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants